Update IDP signin status API explainer #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per discussion at TPAC.
|
@samuelgoto @martinthomson @bvandersloot-mozilla -- could you sanitycheck that this represents what we discussed? |
|
Also should I rename this to "IDP Login Status API" now, since we changed signin to login in the API? |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 20, 2023
As described in https://github.com/fedidcg/login-status and w3c-fedid/FedCM#505 [email protected] Bug: 1451396 Change-Id: I10b4a7b93e72184f86d5116b2708d3918a68573c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4874093 Reviewed-by: Zachary Tan <[email protected]> Commit-Queue: Zachary Tan <[email protected]> Auto-Submit: Christian Biesinger <[email protected]> Cr-Commit-Position: refs/heads/main@{#1199147}
npm1
reviewed
Sep 21, 2023
There was a problem hiding this comment.
If we want to keep this updated, I think there are some more changes needed:
- A few places have "signed-in" or "signed-out" where it should use "logged-in" or "logged-out"
- Should the state naming also change?
- The alternatives considered seciton also needs to be updated. In particular, it still mentions "action=signin".
TallTed
suggested changes
Sep 21, 2023
samuelgoto
reviewed
Sep 25, 2023
|
Just wondering, since there is a lot of duplication between the two explainer, why wouldn't we just point people to this explainer instead [1] for the specifics, and this explainer can go over how FedCM intends to use the signal ? |
TallTed
reviewed
Sep 28, 2023
cbiesinger
commented
Sep 28, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 29, 2023
SHA: aafc66f Reason: push, by samuelgoto Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Sep 30, 2023
SHA: aafc66f Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
npm1
pushed a commit
that referenced
this pull request
Oct 4, 2023
* Update IDP signin status API explainer Per discussion at TPAC. * restrict to secure context * s/signed/logged/g * remove action * ted comments * better describe parsing of the header * review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion at TPAC.